feat: upgrade react-native version, improve example apps #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartoszKlonowski
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
This looks OK! I took care of Windows example, however I indeed noticed the example displays basically nothing for Slider - which is reported in #618, though example itself work OK.
|
Slider patch for Windows #618 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Update to ReactNative 76
Updating ReactNative version to newest, updating example projects - native and web.
Setting in example app new architecture as default in example apps.
Test Plan:
I have tested application after update in both android, ios on both architectures.
Additionally installed library to local project.
Web version works fine.